Merge pull request #230 from MridulS/pathlike_ext

ENH: Extension should be able to accept PathLike sources objects

distutils/extension.py

@@ -4,6 +4,7 @@
 modules in setup scripts."""
 
 import os
+import pathlib
 import warnings
 
 # This class is really only used by the "build_ext" command, so it might
@@ -26,7 +27,7 @@ class Extension:
       name : string
         the full name of the extension, including any packages -- ie.
         *not* a filename or pathname, but Python dotted name
-      sources : [string]
+      sources : [string | os.PathLike]
         list of source filenames, relative to the distribution root
         (where the setup script lives), in Unix form (slash-separated)
         for portability.  Source files may be C, C++, SWIG (.i),
@@ -106,11 +107,16 @@ def __init__(
     ):
         if not isinstance(name, str):
             raise AssertionError("'name' must be a string")
-        if not (isinstance(sources, list) and all(isinstance(v, str) for v in sources)):
-            raise AssertionError("'sources' must be a list of strings")
+        if not (
+            isinstance(sources, list)
+            and all(isinstance(v, (str, os.PathLike)) for v in sources)
+        ):
+            raise AssertionError(
+                "'sources' must be a list of strings or PathLike objects."
+            )
 
         self.name = name
-        self.sources = sources
+        self.sources = list(map(pathlib.Path, sources))
         self.include_dirs = include_dirs or []
         self.define_macros = define_macros or []
         self.undef_macros = undef_macros or []

distutils/tests/test_build_ext.py

@@ -4,6 +4,7 @@
 import textwrap
 import site
 import contextlib
+import pathlib
 import platform
 import tempfile
 import importlib
@@ -335,7 +336,7 @@ def test_get_source_files(self):
         dist = Distribution({'name': 'xx', 'ext_modules': modules})
         cmd = self.build_ext(dist)
         cmd.ensure_finalized()
-        assert cmd.get_source_files() == ['xxx']
+        assert cmd.get_source_files() == [pathlib.Path('xxx')]
 
     def test_unicode_module_names(self):
         modules = [

distutils/tests/test_extension.py

@@ -2,6 +2,7 @@
 
 import os
 import warnings
+from pathlib import Path
 
 from distutils.extension import read_setup_file, Extension
 
@@ -68,13 +69,15 @@ def test_extension_init(self):
         assert ext.name == 'name'
 
         # the second argument, which is the list of files, must
-        # be a list of strings
+        # be a list of strings or PathLike objects
         with pytest.raises(AssertionError):
             Extension('name', 'file')
         with pytest.raises(AssertionError):
             Extension('name', ['file', 1])
         ext = Extension('name', ['file1', 'file2'])
-        assert ext.sources == ['file1', 'file2']
+        assert ext.sources == [Path('file1'), Path('file2')]
+        ext = Extension('name', [Path('file1'), Path('file2')])
+        assert ext.sources == [Path('file1'), Path('file2')]
 
         # others arguments have defaults
         for attr in (