Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add musllinux support (PEP 656) #768

Merged
merged 6 commits into from
Sep 20, 2021
Merged

feat: add musllinux support (PEP 656) #768

merged 6 commits into from
Sep 20, 2021

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Jul 18, 2021 •
edited
Loading

Add musllinux support (PEP 656) allowing to build wheels for musl libc based distros (e.g. Alpine)

Fixes #627

This will remain a draft as long as the following is not available:

In the meantime, some workarounds are used to get this started.

  • cibuildwheel documentation will need some update

cc @lkollar

@mayeut mayeut force-pushed the musllinux branch 7 times, most recently from 6c00d55 to b6554c6 Compare July 25, 2021 14:19
@mayeut mayeut mentioned this pull request Jul 26, 2021
Merged
@mayeut mayeut force-pushed the musllinux branch 3 times, most recently from b0082b1 to 036387c Compare August 2, 2021 12:22
@mayeut mayeut force-pushed the musllinux branch 2 times, most recently from 2cf9188 to be88b34 Compare September 1, 2021 05:47
@minrk minrk mentioned this pull request Sep 16, 2021
Closed
@mayeut mayeut mentioned this pull request Sep 18, 2021
Merged
@mayeut mayeut force-pushed the musllinux branch 2 times, most recently from 5b596cf to 45fc85e Compare September 18, 2021 22:26
@mayeut mayeut marked this pull request as ready for review September 19, 2021 09:22
@mayeut
Copy link
Member Author

mayeut commented Sep 19, 2021

Ready for review !

I think #799 is almost a must have to ease configuration between musllinux & manylinux (that was mentioned by @henryiii yesterday as well).

@mayeut mayeut mentioned this pull request Sep 19, 2021
Merged
3 tasks
@joerick joerick mentioned this pull request Sep 19, 2021
Merged
joerick
joerick reviewed Sep 19, 2021
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! I'd be happy to merge as-is, but, I am wondering if it would work to combine the CIBW_MANYLINUX_*_IMAGE and CIBW_MUSLLINUX_*_IMAGE docs sections...

docs/options.md Outdated Show resolved Hide resolved
docs/options.md Outdated Show resolved Hide resolved
@mayeut
Copy link
Member Author

mayeut commented Sep 19, 2021

This looks great to me! I'd be happy to merge as-is, but, I am wondering if it would work to combine the CIBW_MANYLINUX_IMAGE and CIBW_MUSLLINUX_IMAGE docs sections...

I'll resolve the merge conflict following the PR for cpython 3.10 docs.
I'll add a commit with musllinux/manylinux combined to see what it looks like.

@mayeut
Copy link
Member Author

mayeut commented Sep 19, 2021 •
edited
Loading

I am wondering if it would work to combine the CIBW_MANYLINUX_IMAGE and CIBW_MUSLLINUX_IMAGE docs sections...

@joerick, done, I think it looks better now.

joerick
joerick approved these changes Sep 19, 2021
View reviewed changes
docs/options.md Show resolved Hide resolved
@joerick
Copy link
Contributor

joerick commented Sep 19, 2021

Brilliant! This looks good to me.

@mayeut @joerick
Update docs/options.md
6c28426 
Co-authored-by: Joe Rickerby <joerick@mac.com>
@joerick joerick mentioned this pull request Sep 19, 2021
Merged
henryiii
henryiii approved these changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mayeut
Copy link
Member Author

mayeut commented Sep 20, 2021

Let's merge this in then !

@mayeut mayeut merged commit 803c5e4 into pypa:main Sep 20, 2021
@mayeut mayeut deleted the musllinux branch September 20, 2021 06:18
@henryiii
Copy link
Contributor

🎉 I'll try to rebase my work for #799 on this soon.

@minrk
Copy link
Contributor

minrk commented Oct 4, 2021 •
edited
Loading

Thanks so much for this! 2.2.0a1 worked a treat on pyzmq: zeromq/pyzmq#1622 any additional testing I can do for you folks before uploading musllinux wheels to PyPI?

I excluded musllinux-aarch64 due to a missing dependency (not related to cibuildwheel), but all the others build and appear to work perfectly.

@Budgiebrain994 Budgiebrain994 mentioned this pull request Oct 12, 2021
Closed
@n1ngu n1ngu mentioned this pull request Oct 17, 2021
Closed
@traversaro traversaro mentioned this pull request Oct 31, 2021
Closed
@retornam retornam mentioned this pull request Jun 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerick joerick joerick approved these changes

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

musllinux support (PEP 656)
4 participants
@mayeut @joerick @henryiii @minrk