Allow passing config settings on individual hook basis #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layday
force-pushed
the
feat-config-settings-per-hook
branch
from
b193aad
to
4df3452
Compare
|
Not able to reliably catch the invalid hook warning with Line 70 in 7e0e798 |
Alternative to the flag/env var being discussed to accommodate setuptools. This would enable uses such as `-Cget_requires_for_build_wheel:--tag-build=123 -Cbuild_wheel:--compression=stored` possible.
layday
force-pushed
the
feat-config-settings-per-hook
branch
from
4df3452
to
0ded9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to the flag/env var being discussed to accommodate setuptools. This would enable uses such as
-Cget_requires_for_build_wheel:--tag-build=123 -Cbuild_wheel:--compression=storedpossible.Whether per-hook configuration is desirable remains to be decided, but I thought it was an idea worth exploring.