Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip coords with scalar value #868

Merged

Conversation

GiannisApost
Copy link
Contributor

@GiannisApost GiannisApost commented Jul 24, 2024

Description

Remove scalar coordinates (those with a single value and not indexed).

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--868.org.readthedocs.build/en/868/

@wd60622
Copy link
Contributor

wd60622 commented Jul 24, 2024

Thanks for making this change!
Can you test the functionality and ensure that the original data is not modified

pymc_marketing/mmm/plot.py Outdated Show resolved Hide resolved
@GiannisApost
Copy link
Contributor Author

Checked the functionality with the setup you provided at the issue description and it seems to work. I also checked that it does not modify the original data.

@wd60622
Copy link
Contributor

wd60622 commented Jul 24, 2024

Checked the functionality with the setup you provided at the issue description and it seems to work. I also checked that it does not modify the original data.

Please write a unit test for assurance to other developers

pymc_marketing/mmm/plot.py Outdated Show resolved Hide resolved
@GiannisApost
Copy link
Contributor Author

I wrapped it as a new method and put it into the utils script.

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! Thanks for the change!

@wd60622 wd60622 merged commit 8ee9254 into pymc-labs:main Jul 25, 2024
11 checks passed
@wd60622 wd60622 added enhancement New feature or request plots labels Jul 25, 2024
radiokosmos pushed a commit to radiokosmos/pymc-marketing that referenced this pull request Sep 3, 2024
twiecki pushed a commit that referenced this pull request Sep 10, 2024
twiecki pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip coords with scalar values
2 participants