Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use labs theme as external #830

Merged
merged 4 commits into from
Jul 19, 2024
Merged

use labs theme as external #830

merged 4 commits into from
Jul 19, 2024

Conversation

OriolAbril
Copy link
Collaborator

@OriolAbril OriolAbril commented Jul 11, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--830.org.readthedocs.build/en/830/

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (6619076) to head (662c3cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #830   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          33       33           
  Lines        3285     3285           
=======================================
  Hits         3101     3101           
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OriolAbril
Copy link
Collaborator Author

The logo image is too long now and the navbar doesn't fit on mobile screens, I'll have to think how to handle it

docs/source/index.md Outdated Show resolved Hide resolved
OriolAbril and others added 2 commits July 18, 2024 14:34
Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>
@OriolAbril
Copy link
Collaborator Author

It should be ready to merge, however, it would be great if we could have 3-4 people check the docs website: https://pymc-marketing--830.org.readthedocs.build/en/830/ from their phones to double check everything looks right, no overflows, elements out of place...

@juanitorduz
Copy link
Collaborator

It should be ready to merge, however, it would be great if we could have 3-4 people check the docs website: https://pymc-marketing--830.org.readthedocs.build/en/830/ from their phones to double check everything looks right, no overflows, elements out of place...

Looks great in my phone!

@juanitorduz
Copy link
Collaborator

@wd60622 or @twiecki, can you give it a look (also your phone) 🙏 If there is no issue, we merge. I just wanna have another tested as suggested :)

@wd60622
Copy link
Contributor

wd60622 commented Jul 19, 2024

Good on my end too! Looks great

@juanitorduz juanitorduz merged commit 4cc4ba5 into main Jul 19, 2024
12 checks passed
@juanitorduz juanitorduz deleted the docs_theme branch July 19, 2024 20:23
@juanitorduz
Copy link
Collaborator

Thank you @OriolAbril 🚀

@juanitorduz juanitorduz added docs Improvements or additions to documentation enhancement New feature or request labels Jul 19, 2024
twiecki added a commit that referenced this pull request Sep 10, 2024
* use labs theme as external

* Update docs/source/index.md

Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>

* install theme from pypi

---------

Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>
Co-authored-by: Juan Orduz <juanitorduz@gmail.com>
twiecki added a commit that referenced this pull request Sep 10, 2024
* use labs theme as external

* Update docs/source/index.md

Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>

* install theme from pypi

---------

Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>
Co-authored-by: Juan Orduz <juanitorduz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants