Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve landing page #1023

Merged
merged 28 commits into from
Sep 17, 2024
Merged

Improve landing page #1023

merged 28 commits into from
Sep 17, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Sep 12, 2024

Make the landing page less dense and add a get-started section


📚 Documentation preview 📚: https://pymc-marketing--1023.org.readthedocs.build/en/1023/

@juanitorduz juanitorduz marked this pull request as draft September 12, 2024 11:49
@juanitorduz juanitorduz self-assigned this Sep 12, 2024
@juanitorduz juanitorduz added the docs Improvements or additions to documentation label Sep 12, 2024
@juanitorduz juanitorduz marked this pull request as ready for review September 12, 2024 12:13
@juanitorduz juanitorduz added this to the 0.9.0 milestone Sep 12, 2024
Copy link
Contributor

@drbenvincent drbenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick observations / change requests:

  • "Powered by" should be centred along with the logo
  • MMM table. Great, but can we make it "Feature" and "Benefit" instead of description.
  • I like the inclusion of some badges

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great. Quick Look

@juanitorduz
Copy link
Collaborator Author

Thanks @drbenvincent ! I addressed all of your comments 🙏 (we can do something similar for CausalPy if you want)

@drbenvincent
Copy link
Contributor

That would be great 👍🏻

@OriolAbril
Copy link
Collaborator

OriolAbril commented Sep 13, 2024

OI would need to create a folder for each section and seems a bit cumbersome . Should I do it 🤔 ?

I think it has to do with multiple # title in the same file, no need for different folders but yes different files if you want different entries in the sidebar. Not sure why, but the sidebar will only show the first entry in each file but the inbody toctree shows all top level titles (independently of them being in the same or different files)

It is also possible to remove the right sidebar if you want, even if the page is longish it looks a bit weird in the landing page

Copy link
Contributor

@cluhmann cluhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think the landing page has a huge amount of information on it (e.g., the page is very long), but at least there is a bit more Labs content and it is nearer to the top of the page now.

docs/source/index.md Outdated Show resolved Hide resolved
docs/source/index.md Show resolved Hide resolved
docs/source/index.md Outdated Show resolved Hide resolved
docs/source/index.md Outdated Show resolved Hide resolved
docs/source/getting_started/installation/index.md Outdated Show resolved Hide resolved
@juanitorduz
Copy link
Collaborator Author

I still think the landing page has a huge amount of information on it (e.g., the page is very long), but at least there is a bit more Labs content and it is nearer to the top of the page now.

@cluhmann Agree. Do you think some of the videos can be removed? Which ones?

Co-authored-by: Christian Luhmann <39170995+cluhmann@users.noreply.github.com>
@cluhmann
Copy link
Contributor

@cluhmann Agree. Do you think some of the videos can be removed? Which ones?

Maybe the "Schedule a Free Consultation for MMM & CLV Strategy" and "Support" sections could be trimmed (I can make concrete suggestions).

The "Examples" under the CLV section (the 2x2 table) doesn't seem to do anything? Is this supposed to include links?

Then, under "Resources" I think we can maybe have 1 video and then a link to a page with the rest of the videos? Or to the playlist on YouTube?

@juanitorduz
Copy link
Collaborator Author

@cluhmann I actually removed the Support section as it seemed redundant. I left just three videos: a business case, an mmm and a clv one, WDYT?

Besides that, I think I have addressed all your comments.

@cluhmann
Copy link
Contributor

Let me just do some editing on the "Schedule a Free Consultation" section. Should get to it in a few hours.

Copy link
Contributor

@cluhmann cluhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how these changes look. Not as compact as I had hoped, but a bit better.

docs/source/index.md Outdated Show resolved Hide resolved
docs/source/index.md Outdated Show resolved Hide resolved
docs/source/index.md Outdated Show resolved Hide resolved
docs/source/index.md Outdated Show resolved Hide resolved
docs/source/index.md Outdated Show resolved Hide resolved
docs/source/index.md Show resolved Hide resolved
juanitorduz and others added 6 commits September 17, 2024 19:06
Co-authored-by: Christian Luhmann <39170995+cluhmann@users.noreply.github.com>
Co-authored-by: Christian Luhmann <39170995+cluhmann@users.noreply.github.com>
Co-authored-by: Christian Luhmann <39170995+cluhmann@users.noreply.github.com>
Co-authored-by: Christian Luhmann <39170995+cluhmann@users.noreply.github.com>
Co-authored-by: Christian Luhmann <39170995+cluhmann@users.noreply.github.com>
@juanitorduz
Copy link
Collaborator Author

Thanks @cluhmann ! I think is ready for a last review :)

Copy link
Contributor

@cluhmann cluhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the 1 fix I see.

docs/source/index.md Show resolved Hide resolved
@juanitorduz juanitorduz merged commit 80333ba into main Sep 17, 2024
6 checks passed
@juanitorduz juanitorduz deleted the improve-landing-page branch September 17, 2024 20:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants