Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #259: Annotation in did_skl notebook plot. #306

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

anevolbap
Copy link
Contributor

@anevolbap anevolbap commented Mar 5, 2024

Closes #259.

  • self.y_pred_counterfactual was a list within a list with one element.
  • did_skl.ipynb now runs without errors.

@anevolbap anevolbap changed the title Fix #259: Annotation in did_skl notebook plot . Fix #259: Annotation in did_skl notebook plot. Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (3bb81a7) to head (8b7b208).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          21       21           
  Lines        1380     1380           
=======================================
  Hits         1064     1064           
  Misses        316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drbenvincent
Copy link
Collaborator

Thanks for this @anevolbap 👍🏻

@drbenvincent drbenvincent merged commit 3026ab4 into pymc-labs:main Mar 14, 2024
10 checks passed
@drbenvincent drbenvincent added the bug Something isn't working label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in sci-kit learn version of DifferenceInDifferences.plot method
2 participants