Regression Discontinuity: add ability to specify bandwidth #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 70.40% 71.26% +0.85%
==========================================
Files 19 19
Lines 1007 1044 +37
==========================================
+ Hits 709 744 +35
- Misses 298 300 +2
|
juanitorduz
approved these changes
Jul 24, 2023
| if self.bandwidth is not None: | ||
| fmin = self.treatment_threshold - self.bandwidth | ||
| fmax = self.treatment_threshold + self.bandwidth | ||
| filtered_data = self.data.query(f"{fmin} <= x <= {fmax}") |
There was a problem hiding this comment.
Should we raise a warning when the bandwidth parameter makes the training set very small? Say less than 10 points?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #225.
RegressionDiscontinuityclasses (both pymc and sci-kit learn) now accept an optionalbandwidthkwarg.bandwidthof the threshold.