Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert static glossary into interlinked sphinx glossary #217

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Conversation

drbenvincent
Copy link
Collaborator

This PR converts the current glossary page into a proper sphinx glossary. This allows you to create internal links from notebooks (for example) to the glossary terms. I've also added in a number of these links, but so far I've not been exhaustive about this.

@drbenvincent drbenvincent added the documentation Improvements or additions to documentation label Jul 13, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #217 (889c0d4) into main (106041f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   70.34%   70.34%           
=======================================
  Files          19       19           
  Lines        1005     1005           
=======================================
  Hits          707      707           
  Misses        298      298           

@drbenvincent drbenvincent changed the title Convert static glossary into a proper interlinked sphinx glossary Convert static glossary into interlinked sphinx glossary Jul 13, 2023
@drbenvincent drbenvincent merged commit 5212c79 into main Jul 13, 2023
10 checks passed
@twiecki twiecki deleted the glossary branch July 13, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants