Rename samples argument to draws in sample_prior_predictive
#7366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wd60622
changed the title
draws as parameter in sample_prior_preditivedraws as parameter in sample_prior_predictive
ricardoV94
reviewed
Jun 17, 2024
ricardoV94
added
major
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
ricardoV94
approved these changes
Jun 17, 2024
|
I will switch all samples= in the test suite to draws. It seems to be all over |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
twiecki
approved these changes
Jun 17, 2024
|
Super weird codecov upload failures, I presume unrelated |
|
All tests had passed so merged it. Hopefully the codecov thing is just a fluke |
ricardoV94
changed the title
draws as parameter in sample_prior_predictivesamples argument to draws in sample_prior_predictive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidate with other sampling parameter names
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7366.org.readthedocs.build/en/7366/