Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import pymc.testing #7357

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Fix import pymc.testing #7357

merged 1 commit into from
Jun 15, 2024

Conversation

bomtall
Copy link

@bomtall bomtall commented Jun 15, 2024

Description

  • Move import pytest to be local so it does not break import pymc.testing
  • It is hard to write a test for this because the test will have pytest already

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • [x ] Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7357.org.readthedocs.build/en/7357/

Copy link

welcome bot commented Jun 15, 2024

Thank You Banner]
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (4f76576) to head (9bcc103).
Report is 114 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7357   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         102      102           
  Lines       17207    17210    +3     
=======================================
+ Hits        15895    15898    +3     
  Misses       1312     1312           
Files with missing lines Coverage Δ
pymc/testing.py 91.47% <100.00%> (+0.05%) ⬆️

@twiecki twiecki merged commit 5e82394 into pymc-devs:main Jun 15, 2024
23 checks passed
Copy link

welcome bot commented Jun 15, 2024

Congratulations Banner]
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

@twiecki
Copy link
Member

twiecki commented Jun 15, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pymc.testing attempts to import pytest but pytest is not in pymc install requirements
2 participants