Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid repeated status polling in smc #7351

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

aseyboldt
Copy link
Member

@aseyboldt aseyboldt commented Jun 10, 2024

Description

The smc progress indicator continually polls the status of the worker thread.
This instead uses mutliprocessing.wait to make this more efficient.

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7351.org.readthedocs.build/en/7351/

Copy link
Member

@fonnesbeck fonnesbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fonnesbeck
Copy link
Member

Re-starting failed test. Not clear its related to the change.

@aseyboldt
Copy link
Member Author

The failure was due to the change, good thing we have tests :-)
Only the last finished chain was returned by the sampling function.

@ricardoV94 ricardoV94 added maintenance SMC Sequential Monte Carlo labels Jun 17, 2024
@ricardoV94 ricardoV94 merged commit bc3aea6 into pymc-devs:main Jun 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug SMC Sequential Monte Carlo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants