Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh call to progress bar in apply_function_over_dataset #7343

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

fonnesbeck
Copy link
Member

@fonnesbeck fonnesbeck commented Jun 2, 2024

Description

compute_log_likelihood typically runs so quickly that the progress bar does not update and sits at 0% at the end of the calculation. This adds a refresh call to the progress bar after iteration so that it finishes at 100%.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7343.org.readthedocs.build/en/7343/

@fonnesbeck fonnesbeck requested a review from zaxtax June 2, 2024 20:04
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (508a134) to head (92e252d).
Report is 113 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7343   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         102      102           
  Lines       17208    17209    +1     
=======================================
+ Hits        15896    15897    +1     
  Misses       1312     1312           
Files with missing lines Coverage Δ
pymc/backends/arviz.py 96.61% <100.00%> (+0.01%) ⬆️

@fonnesbeck fonnesbeck merged commit 09ea8c8 into pymc-devs:main Jun 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants