Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for SMC sampling from CustomDist in multiple processes #7337

Closed
wants to merge 1 commit into from

Conversation

EliasRas
Copy link

@EliasRas EliasRas commented May 28, 2024

Description

This PR adds a test which checks whether sample_smc works with models that contain variables defined using CustomDist.
The related issue #7224 couldn't be reproduced and this PR adds just the test from #7241 to check whether errors pop up in CI.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify): New test

📚 Documentation preview 📚: https://pymc--7337.org.readthedocs.build/en/7337/

@ricardoV94
Copy link
Member

test_smc is already running on the Windows job, so we have that covered as well:

- tests/gp/test_cov.py tests/gp/test_gp.py tests/gp/test_mean.py tests/gp/test_util.py tests/ode/test_ode.py tests/ode/test_utils.py tests/smc/test_smc.py tests/sampling/test_parallel.py

@EliasRas
Copy link
Author

EliasRas commented May 28, 2024

By default, multiprocessing creates the worker processes differently on Windows (see https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods)

@aloctavodia
Copy link
Member

@EliasRas Still interested on this PR?

@EliasRas
Copy link
Author

This is just a test PR, the actual work is happening #7241. To answer your question: Yes but I've been waiting for opinions on how to fix the issue in a more generic way.

@EliasRas
Copy link
Author

Closing in favour of #7241.

@EliasRas EliasRas closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants