Get rid of most intX usages #7330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
approved these changes
May 22, 2024
lucianopaz
reviewed
May 23, 2024
| @@ -929,7 +929,7 @@ class Wishart(Continuous): | |||
|
|
|||
| @classmethod | |||
| def dist(cls, nu, V, *args, **kwargs): | |||
| nu = pt.as_tensor_variable(intX(nu)) | |||
| nu = pt.as_tensor_variable(nu, dtype=int) | |||
There was a problem hiding this comment.
What will this default to on the pytensor side?
There was a problem hiding this comment.
The same that numpy does, i.e., int64.
ricardoV94
force-pushed
the
get_rid_of_intX
branch
from
d7d977e
to
33b0e2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed all but one uses of intX, which we started to do in #7114
There is a tricky use in
convert_observed_datathat I will defer until a later PR, as it has more implications than the removals we did.Also got rid of
floatX_arraywhich was just used in tests.Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7330.org.readthedocs.build/en/7330/