Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blackjax version to avoid TypeError on deprecated kwarg #7317

Closed

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 14, 2024

Description

Blackjax tests started failing from an issue that was solved in blackjax-devs/blackjax#664

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7317.org.readthedocs.build/en/7317/

@ricardoV94 ricardoV94 added maintenance jax no releasenotes Skipped in automatic release notes generation dependencies Pull requests that update a dependency file samplers tests labels May 14, 2024
@ricardoV94
Copy link
Member Author

ricardoV94 commented May 14, 2024

It seems that the newer jaxlib which blackjax requires is not available yet on conda.

Do you happen to know something about this @junpenglao (or if I missed something obvious)

@ricardoV94
Copy link
Member Author

ricardoV94 commented May 15, 2024

We may need to mark as xfail until we can install from conda

@twiecki
Copy link
Member

twiecki commented May 16, 2024

Seems like jaxlib builds are broken currently. conda-forge/jaxlib-feedstock#249

@ricardoV94
Copy link
Member Author

I don't understand why did blackjax start failing if we had everything jax/jaxlib/blackjax pinned to a specific version?

Conda-forge still seems stuck at the old v0.4.23 version of jaxlib unfortunately

@ricardoV94
Copy link
Member Author

We should be printing the installed packages in the CI to see what actually got installed

@ricardoV94
Copy link
Member Author

It's installing the wrong version of blackjax ...

@ricardoV94
Copy link
Member Author

Ah we only lower pinned it!

@ricardoV94
Copy link
Member Author

Closing in favor of #7320

@ricardoV94 ricardoV94 closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file jax maintenance no releasenotes Skipped in automatic release notes generation samplers tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants