Fix draws of Weibull when alpha and beta implicitly define size #7288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
approved these changes
Apr 28, 2024
|
Thanks @tomicapretto, great test although a bit unfair that it only exists for this RV. That means I'm okay with no regression test here, but I am definitely not against it either |
ricardoV94
reviewed
Apr 28, 2024
|
Thanks @tomicapretto ! |
9 tasks
ricardoV94
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR incorporates the broadcasting of the shapes of
alphaandbetain the random value generation method from the Weibull distribution to provide a fix to the problem shown in #7220Related Issue
Closes #7220
Type of change
📚 Documentation preview 📚: https://pymc--7288.org.readthedocs.build/en/7288/