Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link and typo in developer_guide.md #7219

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

pipme
Copy link
Contributor

@pipme pipme commented Mar 26, 2024

Description

Fix the link to MH-sampler's astep() method in developer_guide.md. The previous link is not valid and returns 404.

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7219.org.readthedocs.build/en/7219/

Fix link to `MH-sampler`'s `astep()` method.
Copy link

welcome bot commented Mar 26, 2024

Thank You Banner]
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

Copy link
Member

@larryshamalama larryshamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and spotting the typos @pipme :) A small suggestion, might as well include it in this PR?

docs/source/contributing/developer_guide.md Outdated Show resolved Hide resolved
Co-authored-by: larryshamalama <larry.dong@mail.utoronto.ca>
@larryshamalama larryshamalama merged commit 65f0b1e into pymc-devs:main Apr 6, 2024
11 checks passed
Copy link

welcome bot commented Apr 6, 2024

Congratulations Banner]
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

@larryshamalama
Copy link
Member

Sorry @pipme for the delay in merging, and thanks again for your help :)

@ricardoV94 ricardoV94 added the docs label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants