Fix join logp for multivariate RVs #7215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Mar 25, 2024
Comment on lines
+281
to
+283
| ((2,), 5, (2,), 5, 0, False, 0), | ||
| ((2,), 5, (2,), 5, 1, False, 1), | ||
| ((5, 6), 10, (5, 6), 10, 2, False, 2), |
There was a problem hiding this comment.
These graphs were actually supported for a while now, but the logic to test them was wrong so the tests still xfailed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7215 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 100 100
Lines 16888 16889 +1
=======================================
+ Hits 15588 15589 +1
Misses 1300 1300
|
twiecki
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7215.org.readthedocs.build/en/7215/