Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _print_name to Truncated and CustomDists #7205

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Mar 21, 2024

Description

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7205.org.readthedocs.build/en/7205/

@ricardoV94 ricardoV94 changed the title Add print_name to Truncated and CustomDists Add _print_name to Truncated and CustomDists Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.29%. Comparing base (30d00fe) to head (d9687a8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7205      +/-   ##
==========================================
- Coverage   92.29%   90.29%   -2.00%     
==========================================
  Files         100      100              
  Lines       16874    16875       +1     
==========================================
- Hits        15574    15238     -336     
- Misses       1300     1637     +337     
Files Coverage Δ
pymc/distributions/distribution.py 94.29% <ø> (ø)
pymc/distributions/truncated.py 99.40% <100.00%> (+<0.01%) ⬆️

... and 6 files with indirect coverage changes

@jessegrabowski
Copy link
Member

Looks good. Is Truncated the only "wrapper" distribution that needs special treatment? I thinking aboutCensored, maybe?

@ricardoV94
Copy link
Member Author

Looks good. Is Truncated the only "wrapper" distribution that needs special treatment? I thinking aboutCensored, maybe?

Truncated is special because it doesn't just operate on the input dist, but does either icdf or rejection sampling, so it doesn't print the name nicely, whereas for Censored you see something like Censored(normal(0, 1), ...)

@ricardoV94 ricardoV94 merged commit aa679f3 into pymc-devs:main Mar 21, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants