Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression for the variance in ZINB docstring #7200

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

aloctavodia
Copy link
Member

@aloctavodia aloctavodia commented Mar 18, 2024


📚 Documentation preview 📚: https://pymc--7200.org.readthedocs.build/en/7200/

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (a06081e) to head (3a4b471).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7200      +/-   ##
==========================================
+ Coverage   91.87%   92.29%   +0.42%     
==========================================
  Files         100      100              
  Lines       16874    16874              
==========================================
+ Hits        15503    15574      +71     
+ Misses       1371     1300      -71     
Files Coverage Δ
pymc/distributions/mixture.py 95.08% <ø> (ø)

... and 3 files with indirect coverage changes

@ricardoV94
Copy link
Member

@aloctavodia do you have a reference / simple derivation to be able to review non-blindly :D?

@aloctavodia
Copy link
Member Author

I don't have a reference. I got this expression a while ago while working on PreliZ, I found it difficult to get a reference at that time. Then I forgot about it, and found it again this weekend while working on PreliZ. I could try to re-derived... What I did was test it empirically, by generating random samples and computing the variance for a few combinations of parameters.

@ricardoV94 ricardoV94 merged commit 30d00fe into pymc-devs:main Mar 18, 2024
24 checks passed
@ricardoV94
Copy link
Member

No worries then!

@aloctavodia aloctavodia deleted the zinb_docs branch March 18, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants