-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Model.to_graphviz
shortcut
#6865
Conversation
pm.Model
classModel
class
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6865 +/- ##
==========================================
- Coverage 92.03% 91.33% -0.70%
==========================================
Files 96 96
Lines 16369 16448 +79
==========================================
- Hits 15065 15023 -42
- Misses 1304 1425 +121
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the to_graphviz
prefix - not only to align with the original functions, but also to make it more discoverable with other (future) conversion methods. Thinking of to_networkx
..
Co-authored-by: Michael Osthege <michael.osthege@outlook.com>
We still need the string so that this shows up in the release notes. |
Model
classModel.to_graphviz
shortcut
The PR title is all that's needed. Then the label determines in which section it shows up. |
I was using this today, I forgot how it worked and all the explanations assume that people use notebooks: would it make sense to add a return type ( |
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
Do you mind opening an issue for that? I don't think it should block this issue |
Closes #6794
📚 Documentation preview 📚: https://pymc--6865.org.readthedocs.build/en/6865/