Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icdf functions for Moyal, Gumbel, Triangular and Weibull distributions #6802

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

amyoshino
Copy link
Member

@amyoshino amyoshino commented Jun 28, 2023

What is this PR about?
Adds ICDF functions to Moyal, Gumbel, Triangular and Weibull distributions

Issue #6612

References:
Moyal: https://www.wolframalpha.com/input?i=InverseCDF%5BMoyal+Distribution%5D
Gumbel: https://en.wikipedia.org/wiki/Gumbel_distribution ["Random variate generation" section]
Triangular: http://www.math.wm.edu/~leemis/chart/UDR/PDFs/TriangularV.pdf
Weibull: https://www.mathworks.com/help/stats/wblinv.html

Checklist

Major / Breaking Changes

  • ...

New features

  • ...

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • ...

📚 Documentation preview 📚: https://pymc--6802.org.readthedocs.build/en/6802/

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #6802 (928c747) into main (7b08fc1) will decrease coverage by 2.16%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6802      +/-   ##
==========================================
- Coverage   91.92%   89.77%   -2.16%     
==========================================
  Files          95       95              
  Lines       16197    16213      +16     
==========================================
- Hits        14889    14555     -334     
- Misses       1308     1658     +350     
Impacted Files Coverage Δ
pymc/distributions/continuous.py 97.81% <100.00%> (+0.03%) ⬆️

... and 6 files with indirect coverage changes

@amyoshino amyoshino marked this pull request as ready for review June 29, 2023 00:39
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ricardoV94 ricardoV94 merged commit 146afc5 into pymc-devs:main Jun 29, 2023
21 of 22 checks passed
@amyoshino amyoshino deleted the add_continuous_icdf branch June 29, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants