Fix WhiteNoise Covariance bug
#6674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6674 +/- ##
==========================================
- Coverage 91.99% 91.97% -0.02%
==========================================
Files 94 94
Lines 15944 15944
==========================================
- Hits 14667 14664 -3
- Misses 1277 1280 +3
|
Since pymc-devs#6458, Covariance is now the base class for kernels/covariance functions with input_dim and active_dims, which does not include WhiteNoise and Constant kernels.
ricardoV94
changed the title
|
Hey @dehorsley, looks like tests are passing. Ready for review+merge, or is there more you were planning on doing? |
|
Hi @bwengals, yup ready to merge! |
bwengals
approved these changes
Apr 26, 2023
|
|
ricardoV94
changed the title
ricardoV94
changed the title
WhiteNoise Covariance bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #6458, Covariance is now the base class for kernels/covariance functions with input_dim and active_dims, which does not include WhiteNoise and Constant kernels. While #6458 introduced the
BaseCovarianceclass to make this distinction, it looks likeWhiteNoisewas inadvertently not updated to use the new base class.Combination kernels, which use instance of
Covarianceto test for the presents of input_dim and active_dims, fail with aWhiteNoisekernel input.Bugfixes
📚 Documentation preview 📚: https://pymc--6674.org.readthedocs.build/en/6674/