Replace rvs_to_total_sizes mapping by MinibatchRandomVariables #6523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
added
maintenance
major
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6523 +/- ##
=======================================
Coverage 91.91% 91.92%
=======================================
Files 89 90 +1
Lines 14936 14955 +19
=======================================
+ Hits 13729 13747 +18
- Misses 1207 1208 +1
|
ricardoV94
force-pushed
the
remove_totalsize_mapping
branch
from
05e7547
to
bbcf613
Compare
ricardoV94
force-pushed
the
remove_totalsize_mapping
branch
from
bbcf613
to
fc8cf39
Compare
ricardoV94
changed the title
ferrine
approved these changes
Feb 28, 2023
|
|
||
|
|
||
| @_logprob.register(MinibatchRandomVariable) | ||
| def minibatch_rv_logprob(op, values, *inputs, **kwargs): |
There was a problem hiding this comment.
This is much more intuitive now
ricardoV94
force-pushed
the
remove_totalsize_mapping
branch
from
fc8cf39
to
ecba5bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the way rescaling of minibatched variables is achieved, so as to not require keeping any meta-information at the model level.
Ideally, the API would follow that of other RV factories with something like
pm.MinibatchRV(dist=dist, total_size=...)so that we don't have to add any extra complexity at the Model level, but for the sake of backwards compatibility we letModeldo this for now.I removed support for scaling of non-observed RVs even though it would be equally easy to support them. This is a breaking change
Closes #6061
Closes #6332