-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-image workflow #5966
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5966 +/- ##
==========================================
- Coverage 89.42% 89.38% -0.04%
==========================================
Files 73 73
Lines 13292 13249 -43
==========================================
- Hits 11886 11843 -43
Misses 1406 1406
|
To test this, we should (temporarily) change the trigger condition to on:
push: ...and turn off actually pushing it. They also write that the checkout action is not needed, because the In the meantime I'll try to figure out who knows our |
The image appears to be private? It's asking me to log in.. |
I own the docker organization and now created and added these secrets, so this should work now. Can we test it somehow or should we just merge? |
I tested it without the checkout but it failed. |
You should be able to see login in with any user. The image looks like this: |
It can be tested using act executing this command: act release -j build-container -v For that I changed the image name |
I'm merging this, we can always keep working on it in follow-up PRs. But will this now trigger a build we can test or do we need to make a release for that? |
It will be triggered only by release |
Just cut a new release, let's see! |
Does not look promising https://github.com/pymc-devs/pymc/actions/runs/2676293391 |
What is this PR about?
It solves #5939
It add a workflow
docker-image
, The workflow get the labels and tags, build the image, test it and push it to Docker Hub. The workflow will be triggered when there are new releases.It's needed to have the secrets with the Docker Hub user
DOCKERHUB_USER
and tokenDOCKERHUB_TOKEN
.The workflow was tested using act. The test image is in a test image where you can see the tags (latest and version) created. These tags can be modified if needed.
#DataUmbrellaPyMCSprint
...
Checklist