Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert rng_seeder to random_seed in 'Prior and Posterior Predictive Checks' notebook #5896

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

hectormz
Copy link
Contributor

'Prior and Posterior Predictive Checks' notebook on pymc docs site has broken cell(s) because rng_seeder is no longer accepted by Model() #5787

This PR removes rng_seeder and adds rng_seed to the sample() in the cells

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Jun 14, 2022

View / edit / reply to this conversation on ReviewNB

ricardoV94 commented on 2022-06-14T06:08:39Z
----------------------------------------------------------------

You can pass the rng directly, which is a better practice than passing a single number


@review-notebook-app
Copy link

review-notebook-app bot commented Jun 14, 2022

View / edit / reply to this conversation on ReviewNB

ricardoV94 commented on 2022-06-14T06:08:40Z
----------------------------------------------------------------

Same here


@review-notebook-app
Copy link

review-notebook-app bot commented Jun 14, 2022

View / edit / reply to this conversation on ReviewNB

ricardoV94 commented on 2022-06-14T06:08:41Z
----------------------------------------------------------------

And here.

Also can you get rid of the Constant/Mutable warning?


@review-notebook-app
Copy link

review-notebook-app bot commented Jun 14, 2022

View / edit / reply to this conversation on ReviewNB

ricardoV94 commented on 2022-06-14T06:08:41Z
----------------------------------------------------------------

Missing a random_seed here


@hectormz
Copy link
Contributor Author

@ricardoV94 thanks for the comments. I believe I addressed them all

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great!

@ricardoV94 ricardoV94 merged commit 562be37 into pymc-devs:main Jun 14, 2022
@ricardoV94
Copy link
Member

Thanks @hectormz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants