Add a method to compile an aesara forward sampling function #5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #5759 +/- ##
=======================================
Coverage 89.27% 89.27%
=======================================
Files 74 74
Lines 13803 13813 +10
=======================================
+ Hits 12322 12332 +10
Misses 1481 1481
|
ricardoV94
reviewed
May 13, 2022
ricardoV94
reviewed
May 13, 2022
ricardoV94
reviewed
May 13, 2022
ricardoV94
reviewed
May 13, 2022
ricardoV94
reviewed
May 13, 2022
lucianopaz
force-pushed
the
compile_ppc_sampler
branch
from
67c2a13
to
75a3b4a
Compare
ricardoV94
reviewed
May 13, 2022
lucianopaz
force-pushed
the
compile_ppc_sampler
branch
2 times, most recently
from
7ce1a0f
to
10e06bc
Compare
|
@ricardoV94, this is ready for review now. We'll address the |
ricardoV94
reviewed
May 16, 2022
ricardoV94
reviewed
May 16, 2022
|
Looks good, just trying to push to simplify code as much as possible. Left some comments above @lucianopaz |
ricardoV94
reviewed
May 16, 2022
ricardoV94
reviewed
May 16, 2022
lucianopaz
force-pushed
the
compile_ppc_sampler
branch
from
10e06bc
to
c346391
Compare
ricardoV94
reviewed
May 17, 2022
ricardoV94
reviewed
May 17, 2022
lucianopaz
force-pushed
the
compile_ppc_sampler
branch
from
c346391
to
b27a40c
Compare
lucianopaz
force-pushed
the
compile_ppc_sampler
branch
from
b27a40c
to
483dbfb
Compare
ricardoV94
approved these changes
May 17, 2022
There was a problem hiding this comment.
Awesome @lucianopaz! This was actually one of the trickiest blockers for V4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5302
This PR adds a low level method to compile the aesara function responsible for generating forward samples. It introduces the notion of volatile variables in a graph, which allows it to determine which values it should take from an inferred posterior during forward sampling. Volatile variables are variables whose values could change between a run of
pm.sampleand future calls topm.sample_posterior_predictive. These are:vars_in_tracelist (this means that they don't have values in the inferred posterior, so they should be drawn from their a priori assumed distribution)givens_dict, because setting values throughgivensis considered disruptive with respect to the values the variable could have taken duringpm.sample.Tasks that remain before this PR is ready to merge:
compile_forward_sampling_functioninsample_prior_predictive- [ ] Usecompile_forward_sampling_functioninsample_posterior_predictive_w