Removes BART

[aloctavodia]

This removes BART from the main PyMC codebase in favor of moving it to pymc-experimental.

[ricardoV94]

We need to remove the test file from the pytest workflow:

pymc/.github/workflows/pytest.yml

Line 80 in afe210a

pymc/tests/test_bart.py

pymc/.github/workflows/pytest.yml

Line 66 in afe210a

--ignore=pymc/tests/test_bart.py

[ricardoV94]

What about the competence? Is there a level above Ideal that we can give to BART variables?

[codecov]

Codecov Report

Merging #5566 (4635bf3) into main (620b11d) will decrease coverage by 0.52%.
The diff coverage is 92.30%.

❗ Current head 4635bf3 differs from pull request most recent head 5f44242. Consider uploading reports for the commit 5f44242 to get more accurate results

@@            Coverage Diff             @@
##             main    #5566      +/-   ##
==========================================
- Coverage   88.13%   87.61%   -0.53%     
==========================================
  Files          81       76       -5     
  Lines       14238    13694     -544     
==========================================
- Hits        12549    11998     -551     
- Misses       1689     1696       +7     

Impacted Files	Coverage Δ
pymc/__init__.py	100.00% <ø> (ø)
pymc/sampling.py	86.04% <90.00%> (-1.21%)	⬇️
pymc/step_methods/__init__.py	100.00% <100.00%> (ø)
pymc/step_methods/hmc/nuts.py	95.00% <100.00%> (-0.04%)	⬇️
pymc/step_methods/hmc/quadpotential.py	70.57% <0.00%> (-9.98%)	⬇️
pymc/parallel_sampling.py	87.70% <0.00%> (+0.99%)	⬆️
pymc/ode/ode.py	85.85% <0.00%> (+1.01%)	⬆️

[ricardoV94]

Can you give more context what changes with this commit? 159e7bf

[ricardoV94]

Looks good,

Can you add a test for the step methods change, that shows you can add a step method externally?

Also can you split the bart changes from the step/methods assignment into 2 distinct commits (or PRs)?

[aloctavodia]

What should I do to split the changes into 2 distinct commits (or PRs)?

[ricardoV94]

What should I do to split the changes into 2 distinct commits (or PRs)?

git interactive rebase -> reorder + squash all the commits into two commits: 1) remove bart and 2) step method changes

[ricardoV94]

https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

[ricardoV94]

Looks great.

Can you change the commit messages to have a more descriptive title/messages? You don't need to include the titles of the squashed commits unless you want to. This can be done with interactive rebase + reword command

[aloctavodia]

I was confused with how to change the messages. Now I think I got it right.

[ricardoV94]

Looks great. Award for best branch name! Just checking what is going on with read the docs failure

[ricardoV94]

I merged it but just realized we need to mention it in the release notes @aloctavodia