Keep broadcasting information in make_shared_replacements #4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, that's an easy fix. Can you add a test that fails before and passes now with this? |
|
Sure! I'll take care of it in the next days :) |
|
Hi @ExpectationMax ! |
|
@twiecki I think everything should be ready from my side :) |
michaelosthege
approved these changes
Mar 7, 2021
There was a problem hiding this comment.
I added two small suggestions - @ExpectationMax @twiecki please consider them before merging :)
It seems like broadcasting information gets lost when applying `pm.make_shared_replacements`, leading to problems with the metropolis sampler. Potentially related issues below: - #1083 - #1304 - #1983 This fix was previously suggested in the following issue: - #3337 It could be that further adaptations are necessary as indicated in the issue. Strangely, this does not seem to lead to problems when using NUTS.
michaelosthege
approved these changes
Mar 10, 2021
ricardoV94
approved these changes
Mar 10, 2021
|
Thanks @ExpectationMax |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like broadcasting information gets lost when applying
pm.make_shared_replacements, leading to problems with the metropolissampler. Potentially related issues below:
This fix was previously suggested in the following issue:
It could be that further adaptations are necessary as indicated in the
issue. Strangely, this does not seem to lead to problems when using
NUTS.
This fixes issue #4491 and #3337
TODOs: