Improve logsumexp to work with infinite values #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4360 +/- ##
=======================================
Coverage 87.95% 87.95%
=======================================
Files 88 88
Lines 14499 14500 +1
=======================================
+ Hits 12752 12753 +1
Misses 1747 1747
|
AlexAndorra
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
math.logsumexpto work with infinite values, in line with howscipy.special.logsumexpworks.Added new unit tests, comparing the behavior with that of the scipy function. Except for the first two tests, all tests are failing in the current version of master, and pass after the PR.