Add experimental JAX samplers #4247
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #4247 +/- ##
==========================================
- Coverage 88.16% 87.69% -0.47%
==========================================
Files 87 90 +3
Lines 14257 14439 +182
==========================================
+ Hits 12569 12663 +94
- Misses 1688 1776 +88
|
| @@ -64,5 +64,6 @@ Gallery.contents = { | |||
| "MLDA_introduction": "MCMC", | |||
| "MLDA_simple_linear_regression": "MCMC", | |||
| "MLDA_gravity_surveying": "MCMC", | |||
| "MLDA_variance_reduction_linear_regression": "MCMC" | |||
| "MLDA_variance_reduction_linear_regression": "MCMC", | |||
| "GLM-hierarhical-jax": "MCMC", | |||
There was a problem hiding this comment.
just a quick note to say that the mysterious pre-commit error from Check all notebooks appear in table of contents is due to the trailing comma, which json can't parse (and which, as far as I can tell, shouldn't be used in javascript) - I'll look at improving the error message if this happens
| "GLM-hierarhical-jax": "MCMC", | |
| "GLM-hierarhical-jax": "MCMC" |
There was a problem hiding this comment.
No worries!
nbqa NB
What command did you run? If you run
pre-commit run --files docs/source/notebooks/GLM-hierarchical-jax.ipynb
then that should be enough to pass all the (sometimes annoying, admittedly 😳 ) checks
There was a problem hiding this comment.
Oh, neat, it's obviously been too long that I did a PR :). Is this process documented somewhere?
There was a problem hiding this comment.
yup, should all be here https://github.com/pymc-devs/pymc3/wiki/PyMC's-Jupyter-Notebook-Style
There was a problem hiding this comment.
We could also think about enabling pre-commit CI, so that these checks are automatically implemented and committed by pre-commit when they fail
PS: what an exciting PR 🤩
I think it'd be nice to include this one as experimental.
CC @junpenglao