Refine GRW docstrings and fix typos in release notes #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4048 +/- ##
=======================================
Coverage 86.79% 86.79%
=======================================
Files 88 88
Lines 14143 14143
=======================================
Hits 12276 12276
Misses 1867 1867
|
Closed
michaelosthege
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Slack, this PR adds a mention about
theano.tensor.cumsumin GRW docstrings.Turns out we didn't mention that we wanted to drop py36 in the release notes, so it turns out fine 🤷♂️ However, there were a bunch of typos and misses that I took the opportunity to fix with this PR 😉
Thanks for the reviews 🖖