Adding logcdf method to inverse gamma distribution #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfm
changed the title
|
@dfm we are now running on Theano-PyMC, so is it possible to push this over the finish line? |
|
Sure thing! I've fixed the merge conflicts so we'll see if CI passes now. Sorry that I forgot about this one! |
|
It looks like there are precision issues when running at float32 so I marked the test as an |
fonnesbeck
approved these changes
Nov 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #3944 +/- ##
==========================================
+ Coverage 87.59% 88.91% +1.32%
==========================================
Files 88 89 +1
Lines 14312 14433 +121
==========================================
+ Hits 12536 12833 +297
+ Misses 1776 1600 -176
|
|
Needs a line in the release-notes. |
twiecki
approved these changes
Nov 2, 2020
|
@dfm Get a line in the release notes and this will get merged! |
|
Thanks @dfm! |
|
whoops - sorry! Thanks @Spaak, I totally forgot about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3873 for paperwork reasons (sorry about the noise!). See more discussion in that thread.
Since this feature requires an update to Theano, it should not be merged until a (possible) future version of PyMC3 that migrates to a pymc-devs-supported version of Theano.