Remove deprecated stuff #3906
Merged
Remove deprecated stuff #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3906 +/- ##
==========================================
+ Coverage 83.41% 83.43% +0.02%
==========================================
Files 103 103
Lines 14190 14165 -25
==========================================
- Hits 11836 11819 -17
+ Misses 2354 2346 -8
|
twiecki
approved these changes
May 3, 2020
AlexAndorra
pushed a commit
that referenced
this pull request
May 4, 2020
* updated the Hogg notebook * attempted to clarify the kwargs in sample() docstring describing how to pass kwargs to the steppers I believe this fixes #3197 I also noted this need for more clarity in my updated notebook in this PR `pymc3/docs/source/notebooks/GLM-robust-with-outlier-detection.ipynb` * Remove deprecated stuff (#3906) * remove file which is not used * remove deprecated code * repair tests and notebooks that used deprecated API * mention #3906 Co-authored-by: Michael Osthege <zufallsprinzip@hotmail.de> * add deprecation warnings for old backends (#3902) * add deprecation warnings for old backends * mention backend deprecation #3902 * fix typo Co-authored-by: Colin <ColCarroll@users.noreply.github.com> Co-authored-by: Michael Osthege <zufallsprinzip@hotmail.de> Co-authored-by: Colin <ColCarroll@users.noreply.github.com> * minor formatting to notebook and rework of docstring for sample function notebook: dropped all headings one level lower to comply with TOC logic, and very minor language edits sampling.py: clarifired language around single vs compoundstep * updated the Hogg notebook * attempted to clarify the kwargs in sample() docstring describing how to pass kwargs to the steppers I believe this fixes #3197 I also noted this need for more clarity in my updated notebook in this PR `pymc3/docs/source/notebooks/GLM-robust-with-outlier-detection.ipynb` * minor formatting to notebook and rework of docstring for sample function notebook: dropped all headings one level lower to comply with TOC logic, and very minor language edits sampling.py: clarifired language around single vs compoundstep * updates folowing AlexAndorra review: upgrade to arviz=0.7 set prior params to slightly simpler (more justifiable) values, and testvals to simplier defaults explanatory clarifications formatting, typos, * removed the note re step_kwargs, since this PR updates the appropriate docstring * a cell had become markdown, silly. reset it to code and rerun * minor code reformatting via black_nbconvert, final check and re-run * rerun notebook purely as a lazy but safe way to trigger new CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes code that had deprecation warnings since at least version 3.8.