Add QuadPotentialFullAdapt in pm.sample init #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3858 +/- ##
==========================================
- Coverage 90.75% 90.73% -0.03%
==========================================
Files 135 135
Lines 21184 21189 +5
==========================================
Hits 19226 19226
- Misses 1958 1963 +5
|
eigenfoo
requested changes
Mar 28, 2020
There was a problem hiding this comment.
This looks great @techytushar! I've left just one comment below.
It would also be great if you could add a note to the release notes detailing this change.
Once that's fixed, I'm happy to merge!
techytushar
force-pushed
the
pm.sample#3845
branch
from
7699f58
to
8865a5e
Compare
eigenfoo
approved these changes
Mar 28, 2020
|
Thanks for the contribution @techytushar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3845
@ColCarroll @twiecki @eigenfoo I have tried to add
QuadPotentialFullAdaptto thepm.sample. Since I have no experience with this type of sampling, I am not sure whether the initialized mean and covariance are correct. It would be great if you could guide me a little, I'll update the PR with correct initializations.Do I also need to add tests for this?