Support xarray input to sample_posterior_predictive #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3846 +/- ##
==========================================
+ Coverage 90.74% 90.75% +0.01%
==========================================
Files 135 135
Lines 21159 21184 +25
==========================================
+ Hits 19201 19226 +25
Misses 1958 1958
|
* xarray test for fast posterior predictive sampling. * Move Dataset translation to util. The translation from xarray Dataset to a list of points was previously open-coded into sample_posterior_predictive. Pulled it out so it can be used in both spp and fast_sample_posterior_predictive. * fast_sample_posterior_predictive support for xarray traces.
|
@rpgoldman Thanks for expanding this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #3828, making predictions from InferenceData can be very useful.
What this PR does:
InferenceData.posteriorandInferenceData.priortopm.sample_posterior_predictivesample_posterior_predictivesuch that it can feed on thesexarray.Datasetstructures