Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for distributions #3837

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

Ahanmr
Copy link
Contributor

@Ahanmr Ahanmr commented Mar 19, 2020

Shows DeprecationWarning when sd is used instead of sigma

bug: #3688

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #3837 into master will decrease coverage by 0.05%.
The diff coverage is 35.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3837      +/-   ##
==========================================
- Coverage   90.79%   90.73%   -0.06%     
==========================================
  Files         135      135              
  Lines       21113    21130      +17     
==========================================
+ Hits        19170    19173       +3     
- Misses       1943     1957      +14     
Impacted Files Coverage Δ
pymc3/distributions/timeseries.py 70.89% <0.00%> (-0.76%) ⬇️
pymc3/distributions/continuous.py 80.10% <23.07%> (-0.76%) ⬇️
pymc3/distributions/mixture.py 87.27% <50.00%> (-0.35%) ⬇️
pymc3/distributions/multivariate.py 78.93% <100.00%> (ø)
pymc3/step_methods/hmc/base_hmc.py 95.32% <0.00%> (-0.94%) ⬇️

@twiecki
Copy link
Member

twiecki commented Mar 19, 2020

Yes, I think it's time. @fonnesbeck @junpenglao @ColCarroll et al what do you think?

@junpenglao junpenglao changed the title partially fixes #3688 Improve documentation for distributions Mar 19, 2020
@junpenglao junpenglao linked an issue Mar 19, 2020 that may be closed by this pull request
@junpenglao
Copy link
Member

I think it is time as well.

@twiecki twiecki merged commit 40d9597 into pymc-devs:master Mar 19, 2020
twiecki added a commit that referenced this pull request Mar 19, 2020
@twiecki
Copy link
Member

twiecki commented Mar 19, 2020

Ah, forgot that we need a line in the release notes, can you add that @Ahanmr in a separate PR?

@Ahanmr
Copy link
Contributor Author

Ahanmr commented Mar 19, 2020

@twiecki Yeah, I'll that in the release notes as a point in Maintenance, for version 3.9?

@twiecki
Copy link
Member

twiecki commented Mar 19, 2020

@Ahanmr yep.

@Ahanmr Ahanmr mentioned this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation of some distributions is confusing
3 participants