Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix multiplication infix operator #3619

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Conversation

ColCarroll
Copy link
Member

This adds support for @ matrix multiplication. Also fixes #3618 once we cut a release 😁

Note this is a bit of overkill, in that I just wrap theano's TensorVariable, and defer multiplication to tt.dot. I could instead add these methods to each class, but this felt better.

I am not sure if I should also update pm.data.GenTensorVariable -- I decided not to, since minibatch matrix multiplication seems... tricky.

@fonnesbeck
Copy link
Member

Good idea! I See no problems with the implementation.

@fonnesbeck
Copy link
Member

Doesn't have to be here, but maybe we can replace some tt.dot calls in the notebooks to make folks aware this works.

@ericmjl
Copy link
Member

ericmjl commented Sep 6, 2019

Hitting merge!

@ericmjl ericmjl merged commit 4c771f6 into pymc-devs:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quickstart regression example fails -- ValueError: setting an array element with a sequence.
3 participants