Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair parallelized population sampling #3559

Merged

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Jul 21, 2019

Without setting sample(cores=…) the default behavior (when using population steppers) changes to parallelization. However, there is an informative log message informing the user that setting sample(cores=1) turns off the parallelization.

@michaelosthege michaelosthege changed the title [WIP] Repair parallelized population sampling WIP: Repair parallelized population sampling Jul 21, 2019
@michaelosthege michaelosthege changed the title WIP: Repair parallelized population sampling Repair parallelized population sampling Jul 21, 2019
Copy link
Member

@ColCarroll ColCarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

pymc3/sampling.py Show resolved Hide resolved
pymc3/sampling.py Outdated Show resolved Hide resolved
Co-Authored-By: Colin <ColCarroll@users.noreply.github.com>
@junpenglao junpenglao merged commit 21eb865 into pymc-devs:master Jul 26, 2019
@michaelosthege michaelosthege deleted the fix-population-parallelization branch August 7, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants