Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numdifftools #3485

Merged
merged 2 commits into from
May 21, 2019
Merged

Remove numdifftools #3485

merged 2 commits into from
May 21, 2019

Conversation

ColCarroll
Copy link
Member

This fixes a problem from #3468, and also one that @twiecki brought up in pbrod/numdifftools#42, specifically: the most current version of numdifftools on pypi uses an old version of scipy.

I do not entirely understand what this code is doing, but I get the impression we are using numdifftools for more experimental stuff, which I have just removed.

If anyone is concerned, I can do more research into what exactly this is doing, but no PRs will pass CI until we do one of the following, in my order of preference:

  • remove numdifftools (this approach)
  • install numdifftools from github in requirements-dev.txt
  • pin scipy to an earlier verison
  • something else?

@twiecki
Copy link
Member

twiecki commented May 21, 2019 via email

@twiecki
Copy link
Member

twiecki commented May 21, 2019

Thought about this some more and this is a pretty obvious case, we don't need a decaying dependency for just a single test.

************* Module pymc3.tests.test_distributions
pymc3/tests/test_distributions.py:6: [W0611(unused-import), ] Unused Potential imported from model
pymc3/tests/test_distributions.py:7: [W0611(unused-import), ] Unused DictToArrayBijection imported from blocking
pymc3/tests/test_distributions.py:7: [W0611(unused-import), ] Unused ArrayOrdering imported from blocking

@twiecki
Copy link
Member

twiecki commented May 21, 2019

Also needs release-notes.

@lucianopaz lucianopaz merged commit 8597aef into pymc-devs:master May 21, 2019
@lucianopaz
Copy link
Contributor

Thanks @ColCarroll!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants