-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positives for superfluous-parens
#4784
Merged
Pierre-Sassoulas
merged 12 commits into
pylint-dev:main
from
DanielNoord:superfluous-parens
Aug 3, 2021
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
319f101
Split functional tests for ``superfluous-parents``
DanielNoord 9a2ce9a
Fix false positives for superfluous-parens
DanielNoord 1b2a98e
Merge branch 'main' into superfluous-parens
DanielNoord 20e4453
Move the superfluous functional tests to functional/s/super
Pierre-Sassoulas ab87cea
Add the content of the unittest in functional tests
Pierre-Sassoulas b9e0d8c
Fix strange fail by using process_token instead
Pierre-Sassoulas 426e0dc
Remove failing unittest, covered by functional
DanielNoord 69bf577
Update tests/functional/s/super/superfluous_parens_walrus_py38.py
DanielNoord 5345638
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7b0b2ff
Fix tests
DanielNoord 3f737cb
Add TODO
DanielNoord ee29f72
Add fixme to ignore list
DanielNoord File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
tests/functional/s/super/superfluous_parens_walrus_py38.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
"""Test the superfluous-parens warning with python 3.8 functionality (walrus operator)""" | ||
# pylint: disable=missing-function-docstring,invalid-name | ||
if not (x := False): | ||
print(x) | ||
|
||
if not ((x := 1)): # [superfluous-parens] | ||
pass | ||
|
||
if not ((((x := 1)))): # [superfluous-parens] | ||
pass | ||
|
||
i = 1 | ||
y = 1 | ||
|
||
if odd := is_odd(i): # [undefined-variable] | ||
pass | ||
if not (foo := 5): | ||
pass | ||
|
||
if not ((x := y)): # [superfluous-parens] | ||
pass | ||
|
||
if ((x := y)): # [superfluous-parens] | ||
pass | ||
DanielNoord marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[testoptions] | ||
min_pyver=3.8 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
superfluous-parens:6:0::Unnecessary parens after 'not' keyword:HIGH | ||
superfluous-parens:9:0::Unnecessary parens after 'not' keyword:HIGH | ||
undefined-variable:15:10::Undefined variable 'is_odd':HIGH | ||
superfluous-parens:20:0::Unnecessary parens after 'not' keyword:HIGH | ||
superfluous-parens:23:0::Unnecessary parens after 'if' keyword:HIGH |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this comment to 416 because I believe it cover 417-418 and is misplaced in the current code.