Fix functional tests

pylint-dev · Aug 1, 2021 · 137e469 · 137e469
1 parent 33bdace
commit 137e469
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/pylint/checkers/format.py b/pylint/checkers/format.py
@@ -404,7 +404,7 @@ def _check_keyword_parentheses(
                         self.add_message(
                             "superfluous-parens", line=line_num, args=keyword_token
                         )
-                    continue
+                    return
                 # ')' can't happen after if (foo), since it would be a syntax error.
                 if tokens[i + 1].string in (":", ")", "]", "}", "in") or tokens[
                     i + 1

diff --git a/tests/checkers/unittest_format.py b/tests/checkers/unittest_format.py
@@ -269,9 +269,9 @@ def test_disable_global_option_end_of_line():
     Test for issue with disabling tokenizer messages
     that extend beyond the scope of the ast tokens
     """
-    file_ = tempfile.NamedTemporaryFile(  # pylint: disable=consider-using-with
+    file_ = tempfile.NamedTemporaryFile(
         "w", delete=False
-    )
+    )  # pylint: disable=consider-using-with
     with file_:
         file_.write(
             """

diff --git a/tests/functional/s/superfluous_parens.py b/tests/functional/s/superfluous_parens.py
@@ -19,7 +19,7 @@
 del DICT["b"]
 del DICT["a"]
 
-i = [x for x in ((3, 4) if 1 else (5, 6))]
+i = [x for x in ((3, 4) if 1 > 0 else (5, 6))]
 i = [x for x in ((3, 4))]  # [superfluous-parens]
 
 

diff --git a/tests/functional/s/superfluous_parens.txt b/tests/functional/s/superfluous_parens.txt
@@ -1,4 +1,4 @@
 superfluous-parens:8:0::Unnecessary parens after 'not' keyword
 superfluous-parens:14:0::Unnecessary parens after 'if' keyword
 superfluous-parens:23:0::Unnecessary parens after 'in' keyword
-superfluous-parens:25:0::Unnecessary parens after 'in' keyword
+superfluous-parens:27:0::Unnecessary parens after 'in' keyword
diff --git a/tests/functional/s/superfluous_parens_walrus_py38.txt b/tests/functional/s/superfluous_parens_walrus_py38.txt
@@ -1 +1 @@
-superfluous-parens:4:0::Unnecessary parens after 'in' keyword
+superfluous-parens:6:0::Unnecessary parens after 'not' keyword