Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3.13 compatibility re: collections.abc #2598

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes pylint-dev/pylint#10000

@jacobtylerwalls jacobtylerwalls added the Needs backport Needs to be cherry-picked on the current patch version by an astroid's maintainer label Oct 4, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.3.5 milestone Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 93.25%. Comparing base (6dba72c) to head (59a3429).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2598   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files          93       93           
  Lines       11044    11050    +6     
=======================================
+ Hits        10299    10305    +6     
  Misses        745      745           
Flag Coverage Ξ”
linux 93.14% <100.00%> (+<0.01%) ⬆️
pypy 93.25% <100.00%> (+<0.01%) ⬆️
windows 93.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
astroid/brain/brain_collections.py 100.00% <100.00%> (ΓΈ)

@Pierre-Sassoulas Pierre-Sassoulas merged commit f63a393 into main Oct 4, 2024
20 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the python-313-collections-abc branch October 4, 2024 08:18
Copy link
Contributor

github-actions bot commented Oct 4, 2024

The backport to maintenance/3.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2598-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f63a39368dd422d49d77c42a7dd6dad00ee1a986
# Push it to GitHub
git push --set-upstream origin backport-2598-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x

Then, create a pull request where the base branch is maintenance/3.3.x and the compare/head branch is backport-2598-to-maintenance/3.3.x.

jacobtylerwalls added a commit to jacobtylerwalls/astroid that referenced this pull request Oct 4, 2024
Pierre-Sassoulas pushed a commit that referenced this pull request Oct 4, 2024
@jacobtylerwalls jacobtylerwalls removed the Needs backport Needs to be cherry-picked on the current patch version by an astroid's maintainer label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python 3.13.0rc3 and collections.abc
3 participants