Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify tqdm use #87

Merged
merged 2 commits into from
Feb 7, 2023
Merged

modify tqdm use #87

merged 2 commits into from
Feb 7, 2023

Conversation

geezacoleman
Copy link
Contributor

slight variation to the use of tqdm already added from #85 . Included in all importers/exports and with a defined length for progress/time remaining estimation.

Progress bar style can be updated as per some of the examples here by changing pbar = tqdm(desc="", total=length_of_files, ascii=' ='). Colour etc. can also be changed, but maybe not so critical!

@alexheat
Copy link
Contributor

alexheat commented Feb 6, 2023

Hi @geezacoleman thank you for making a contribution. Your new code has failed one of the automated tests so I want to resolve that before checking it in. You can see how to run the tests on your side here https://github.com/pylabel-project/pylabel/tree/dev/tests

changed `total=range(...)' to `total=df.shape[0]`
@geezacoleman
Copy link
Contributor Author

It looks like I left total=range(0, df.shape[0]) when it should just be total=df.shape[0] for setting up the progress bar in the COCO exporter. This seems to fix that error on my end.

@alexheat alexheat merged commit 680ad74 into pylabel-project:dev Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants