Fix (F)Rect.scale_by(_ip) handling of the scale_by parameter
#3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzpr3d4t0r
reviewed
Aug 22, 2024
Matiiss
reviewed
Aug 30, 2024
Matiiss
changed the title
scale_by(_ip) argument handling(F)Rect.scale_by(_ip) handling of the scale_by parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scale_bywas incorrectly returning a valid object even when the underlyingscale_by_ipoperation was failing. This PR fixes this and also the memleak resulting from it.scale_byargument was keyword only so far, and the docs didn't make a mention of this. So I updated the implementation to handle a sequence scale if it is passed positionally