Fix interactive midi test_time with pytest test -s
#3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
reviewed
Jul 28, 2024
| self.assertTrue(0 <= mtime < 100) | ||
| if "pytest" in sys.modules: | ||
| # under pytest the midi module takes a couple of seconds to init | ||
| # instead of milliseconds |
There was a problem hiding this comment.
I'm curious why this is happening. How does using pytest slow down midi?
|
Absolutely no idea!
…On Sun, 28 Jul 2024, 12:12 Ankith, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/midi_test.py
<#3018 (comment)>
:
> @@ -319,8 +320,14 @@ def test_get_init(self):
def test_time(self):
mtime = pygame.midi.time()
self.assertIsInstance(mtime, int)
- # should be close to 2-3... since the timer is just init'd.
- self.assertTrue(0 <= mtime < 100)
+ if "pytest" in sys.modules:
+ # under pytest the midi module takes a couple of seconds to init
+ # instead of milliseconds
I'm curious why this is happening. How does using pytest slow down midi?
—
Reply to this email directly, view it on GitHub
<#3018 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADGDGGXHAJE5YOGTRFYKTXDZOUQ7ZAVCNFSM6AAAAABLOPX4GGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBTGU2DANRZGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ankith26
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little while ago @ankith26 changed something to make pytest work better with out test suite. I like the output of pytest so I was trying it out today and, after a little fidddling I realised we need to run it with the
-sflag, like so:to make all the command line unit tests work.
Anyway, with that they all seem to work OK through pytest, bar two tests. This 'how much time has passed since
midi.init()was called was one of them - for some reason it takes at least 10 times as long to go frompygame.midi.init()topygame.midi.time()when running the test through pytest. I'm not sure if we want to cater to pytest by making a small change to this test or not, but anyway I though I'd submit a PR.The test for
set_gamma_ramp()also doesn't pass now - I think it should probably be removed as the function is deprecated in pygame, the corresponding SDL function is also deprecated and it doesn't work at all on my PC at all anymore - I expect windows has removed support for it.The other thing running pytest does is show all the deprecated functions we are testing in the tests without supressing the generated warnings - this make the test output a bit messy and harder to spot deprecation warnings not coming from our test code.
Warnings output from pytest test -s