Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect & create conda environments #327

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lmmarsano
Copy link
Contributor

pyenv virtualenv fails to create conda environments from conda environments.

$ pyenv virtualenv lsp test
Looking in links: /tmp/tmp0ao0gi5w
Requirement already satisfied: setuptools in /home/LOM0227/.pyenv/versions/miniconda3-latest/envs/test/lib/python3.7/site-packages (40.8.0)
Requirement already satisfied: pip in /home/LOM0227/.pyenv/versions/miniconda3-latest/envs/test/lib/python3.7/site-packages (19.0.3)
$ pyenv versions
* system (set by /home/LOM0227/.pyenv/version)
  lsp
  miniconda3-latest
  miniconda3-latest/envs/lsp
  miniconda3-latest/envs/test
  test
$ conda info -e
# conda environments:
#
base                  *  /home/LOM0227/.pyenv/versions/miniconda3-latest
lsp                      /home/LOM0227/.pyenv/versions/miniconda3-latest/envs/lsp

Instead, it attempts to make python venv environments.
These updates reuse logic from #290 to detect conda environments, detect conda base environments, and clone non-base environments supplied as version to pyenv virtualenv.

lmmarsano and others added 3 commits October 9, 2019 06:08
non-base conda environments lack bin/conda
apply same solution as pyenv#290
detect base conda by testing for `envs` directory
create or clone accordingly
Copy link
Member

@native-api native-api left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests that specifically check this use case. Those need to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants