Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy the data of the DatetimeIndex in the Dataset.chunk-by-frequency tests #9419

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Sep 1, 2024

Looks like pd.DatetimeIndex.to_numpy will return a immutable view by default, so we have to specify that we want a copy instead.

(Note: this, together with #9403, allows us to close the upstream-dev issue #9277)

@keewis keewis requested a review from dcherian September 1, 2024 16:23
@keewis keewis added the run-upstream Run upstream CI label Sep 1, 2024
@dcherian dcherian merged commit a539b72 into pydata:main Sep 3, 2024
31 of 34 checks passed
@keewis keewis deleted the chunk-frequency-read-only branch September 3, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-upstream Run upstream CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants