Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark-theme in html[data-theme=dark]-tags #9200

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

prisae
Copy link
Contributor

@prisae prisae commented Jul 1, 2024

This is similar to #6500 and #6501 : In my docs, the dark-theme is noted in the html-part as

html< ... data-theme=dark ... >

and xarray-tables look therefore awful with the dark theme, as they are not rendered properly, as can be seen, e.g., here: https://emsig.xyz/emg3d-gallery/gallery/tutorials/simulation.html#create-survey.

This can be fixed by extending

html[theme=dark],
body[data-theme=dark],
body.vscode-dark {

to

html[theme=dark],
html[data-theme=dark],
body[data-theme=dark],
body.vscode-dark {
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

Copy link

welcome bot commented Jul 1, 2024

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@dcherian
Copy link
Contributor

dcherian commented Jul 1, 2024

Thanks!

@dcherian dcherian merged commit 24ab84c into pydata:main Jul 1, 2024
27 of 28 checks passed
Copy link

welcome bot commented Jul 1, 2024

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! celebration gif

@prisae prisae deleted the dark-theme branch July 1, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants